-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
302 app.update.background.scheduling.enabled
still in use? [A: yes, but deprecated in v96]
#1325
Comments
Do you use Windows? |
Yep. I was on my Windows 10 machine when I was looking into this. |
Onl appearance in firefox' code base (without system extensions?): // To be thorough, remove any traces of the pref that used to control the
// default value that we just set. We don't want any users to have the
// impression that that pref is still useful.
Services.prefs.clearUserPref("app.update.background.scheduling.enabled"); https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/BackgroundUpdate.jsm#340 |
this was already on my radar. it's difficult, because I use portables. I do have two installed (Beta, Nightly) and I don't install any maintenance services - and there have been changes happening in the last several releases, ongoing I don't actually think the pref does anything anymore, toggling the UI changes a different pref
I think the pref to actually use is As I said, this is on my radar, but it's not high priority - except for ME I don't want my test-suite of portables moving forward to update. I already have issues with ESR78/91 32bit portables from retaining their JSON files
All browsers are set to FF65-95
Dev96 (portable)
Beta96 (installed)
Nightly
So as you can see there are changes, and I was waiting to see what rolls down into stable What I could do is toggle notes I have
note the |
nightly 97 + beta 96 (both installed) and dev (portable) have the following FF95, 94, 93 (all portables) do not that the setting: I will need to check back to when I added it and follow the bugzillas down the rabbi hole - maybe the UI is/was dependent on the release channel It's weird because I always check settings exist: but maybe I added this before stable and relied on dev/beta/nightly |
This will be covered in FF95-FF96 diffs In FF96+ there are four combinations (windows users) of the two values
do not exist in about:config
four combos
In all the above tests, the ONLY difference in prefs between ALL four of them is
case B is cosmetic, and if the user already has to manually change update settings in windows, then the sub-menu item can be done at the same time The only thing left that I want to test is what the hidden pref |
app.update.background.enabled = false: test from about:config and from user.js setup config to be no auto-installs but the submenu item for background is dimmed out but checked
So the background update is the same as closing, the pref in OP is deprecated in FF95-FF96 diffs, will do it there |
app.update.background.scheduling.enabled
still in use?app.update.background.scheduling.enabled
still in use? [A: deprecated in v96]
also tidy the description to reflect that the setting is hidden
app.update.background.scheduling.enabled
still in use? [A: deprecated in v96]app.update.background.scheduling.enabled
still in use? [A: yes, but deprecated in v96]
@Thorin-Oakenpants is there a "typo" in |
there is no typos, the values were copy pasted from the JSON file |
user.js/user.js
Lines 143 to 146 in 06b8d8b
This is not an option in
about:config
for Firefox Nightly 97 and Beta/Dev 96.If it is a pref the user needs to create, then we should add
// [HIDDEN PREF]
to the end.The text was updated successfully, but these errors were encountered: