Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ciphers #931

Closed
Thorin-Oakenpants opened this issue Apr 23, 2020 · 6 comments
Closed

ciphers #931

Thorin-Oakenpants opened this issue Apr 23, 2020 · 6 comments

Comments

@Thorin-Oakenpants
Copy link
Contributor

expanding on #905

Just things to consider

  • JA3 link (https://jwlss.pw/ja3/)
  • extra test link (browserleaks)
  • expand list of weak ciphers
  • explain why each type is weak
  • stats:

some notes from @rusty-snake : this is ALL the ciphers

/* 1261: disable 3DES (effective key size < 128)
 * [1] https://en.wikipedia.org/wiki/3des#Security
 * [2] https://en.wikipedia.org/wiki/Meet-in-the-middle_attack
 * [3] https://www-archive.mozilla.org/projects/security/pki/nss/ssl/fips-ssl-ciphersuites.html ***/
   // user_pref("security.ssl3.rsa_des_ede3_sha", false);

/* xxxx: Disable weak CIPHERS
   128: 
   SHA1:
   CBC:
   NOPFS:
   DHE:
***/
   // user_pref("security.ssl3.ecdhe_ecdsa_aes_128_sha", false); // 128; SHA1; CBC;
   // user_pref("security.ssl3.ecdhe_rsa_aes_128_sha", false); // 128; SHA1; CBC;
   // ^^ was 1262: disable 128 bits

   // user_pref("security.ssl3.dhe_rsa_aes_128_sha", false); // 128; SHA1; CBC; DHE;
   // user_pref("security.ssl3.dhe_rsa_aes_256_sha", false); // SHA1; CBC; DHE;
   // was 1263: disable DHE (Diffie-Hellman Key Exchange)
   // https://www.eff.org/deeplinks/2015/10/how-to-protect-yourself-from-nsa-attacks-1024-bit-DH

   // user_pref("security.ssl3.rsa_aes_128_sha", false); // 128; SHA1; CBC; NOFPS;
   // user_pref("security.ssl3.rsa_aes_256_sha", false); // SHA1; CBC; NOFPS;
   // was 1264: disable other (which is not a very helpful description)

   // user_pref("security.ssl3.ecdhe_ecdsa_aes_256_sha", false); // SHA1; CBC;
   // user_pref("security.ssl3.ecdhe_rsa_aes_256_sha", false); // SHA1; CBC;
  // ^^ last two are the new ones

@rusty-snake
Copy link
Contributor

@rusty-snake
Copy link
Contributor

/* xxxx: Disable weak ciphers
   All these use SHA1 and CBC which should be considered broken. [1] [2]
   128: 
   NOPFS: https://en.wikipedia.org/wiki/Forward_secrecy
   DHE: Diffie-Hellman key exchange w/o Elliptic-curves
   [1]: https://en.wikipedia.org/wiki/SHA-1#Attacks
   [2]: https://en.wikipedia.org/wiki/POODLE#POODLE_attack_against_TLS
***/
   // user_pref("security.ssl3.ecdhe_ecdsa_aes_128_sha", false); // 128;
   // user_pref("security.ssl3.ecdhe_rsa_aes_128_sha", false); // 128;
   // ^^ was 1262: disable 128 bits

   // user_pref("security.ssl3.dhe_rsa_aes_128_sha", false); // 128; DHE;
   // user_pref("security.ssl3.dhe_rsa_aes_256_sha", false); // DHE;
   // was 1263: disable DHE (Diffie-Hellman Key Exchange)
   // https://www.eff.org/deeplinks/2015/10/how-to-protect-yourself-from-nsa-attacks-1024-bit-DH

   // user_pref("security.ssl3.rsa_aes_128_sha", false); // 128; NOFPS;
   // user_pref("security.ssl3.rsa_aes_256_sha", false); // NOFPS;
   // was 1264: disable other (which is not a very helpful description)

   // user_pref("security.ssl3.ecdhe_ecdsa_aes_256_sha", false);
   // user_pref("security.ssl3.ecdhe_rsa_aes_256_sha", false);
  // ^^ last two are the new ones

@earthlng
Copy link
Contributor

I like https://ja3er.com/ because it works without JS

@Thorin-Oakenpants
Copy link
Contributor Author

https://phabricator.services.mozilla.com/D66270

@crssi
Copy link

crssi commented Jun 10, 2020

^^ shouldn't every ssl3 be disabled?

@Thorin-Oakenpants
Copy link
Contributor Author

There are other tickets for other ciphers and it will depend on what uses them

Thorin-Oakenpants added a commit that referenced this issue Jun 27, 2020
- adds the new tests including the non-JS JA3
- Stats: the code numbers are from https://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/nsNSSCallbacks.cpp#903
- Telemetry from SSL_CIPHER_SUITE_FULL: 
   - go to https://telemetry.mozilla.org/
   - click Measurement Dashboard, etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants