Fix paths for Windows users #957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielBertocci Thank you so much for implementing this! I actually already implemented a fix for the same thing on my dev branch and will publish it today. Again though, I really appreciate the initiative and would love to work together on any other issues you run into in the future! |
|
Oh, I missed that fix, thank you for pointing it out! |
|
@DanielBertocci No you couldn't have known without checking the commits on my dev branch, I should have just prioritized getting it merged yesterday. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Windows:
fromCwd()returns a string with backslashes.ts.parseJsonConfigFileContentreturns the paths with slashes.This causes
this.rootFiles = tsConfigInfo.parsed.fileNames.filter(path => path.startsWith(fromCwd()));to match no files.With this update the path check is safer.