Fix the panic subgroup_fft_in_place benchmark for MNT6-753's Fr
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weikengchen
requested review from
ValarDragon and
Pratyush
and removed request for
ValarDragon
|
All tests except the linter pass. |
Pratyush
approved these changes
May 26, 2021
weikengchen
added a commit
that referenced
this pull request
May 28, 2021
* parallelize miller loops * completed bls12 miller_loop parallelization * restores logic for when parallel feature is off * cargo cleanups * cleanups * cargo fmt * adds changelog entry * fixed changelog * moved to cfg_iter, cleanups * formatting * minor fixes * minor fixes * Bump the version of super-linter (#283) * Fix the panicking `subgroup_fft_in_place` benchmark for MNT6-753's Fr (#284) * fix the bench test failure * update the CHANGELOG * lint * lint * Implement `Into<BigUint>` and `From<BigUint>` for `BigInteger` and `PrimeField` (#280) * add into and from BigUint for BigInteger * update changelog, cargo fmt * linter * update changelog, cargo fmt * change the algorithm; implement for PrimeField as well * less confusing variable name * for BigInteger, do TryFrom instead of From; for PrimeField, do a mod * handle the error of TryFrom; add a test for Fr into/from BigUint * fmt, clippy * Add sparse scalar mul and sub (#259) * Add/Sub impl for Sparse and Dense polys, Mul<F> for SparsePolynomial * Add test and update changelog * Fmt * Update CHANGELOG.md * add add_assign and sub_assign * fmt Co-authored-by: Weikeng Chen <w.k@berkeley.edu> * parallelize miller loops * completed bls12 miller_loop parallelization * restores logic for when parallel feature is off * cargo cleanups * cleanups * cargo fmt * adds changelog entry * fixed changelog * moved to cfg_iter, cleanups * formatting * minor fixes * minor fixes Co-authored-by: Weikeng Chen <w.k@berkeley.edu> Co-authored-by: Ryan Lehmkuhl <ryanleh.ob@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
subgroup_fft_in_placebenchmark tests MNT6-753's Fr using a polynomial of degree larger than the capacity of the field. This PR uses smaller degrees for MNT6-753's Fr, while still using higher degrees for the BLS12-381 benchmark.closes: #281
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorerN/A:
Tested locally.