Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Initial Circom 2 support #10
WIP: Initial Circom 2 support #10
Changes from 10 commits
6002529
6a7c360
5d967fc
ceb20c9
1d110f0
ae93f04
01f65b8
4051bde
14c45fd
19faa5c
37bb1e4
e934fca
2b3d94a
97ce16a
28ddd22
dbcd1aa
2cae186
b4271e1
efa60ea
2e39422
06f79d7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could perhaps create a
struct CircomBase
(for any shared functions),struct Circom
(for 1.0) andstruct Circom2
(for 2.0) to better separate 1.0 vs 2.0 functions, and instantiate thestruct Wasm
with one or the other based on the feature?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried a few different things here, with enums/generics etc. The current trait version is the one that that seemed somewhat sensible and I managed to get to compile 😅 Let me know what you think.