Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI by fixing version + add toolchain file #52

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

tyshko-rostyslav
Copy link
Collaborator

Closes #50

@tyshko-rostyslav tyshko-rostyslav marked this pull request as ready for review July 24, 2023 12:59
@Pratyush
Copy link
Member

Hm were you able to figure out why there's a bug with using newer versions of Rust?

@tyshko-rostyslav
Copy link
Collaborator Author

Hm were you able to figure out why there's a bug with using newer versions of Rust?

@Pratyush Reason is misaligned pointers in wasmer. Why this happens in wasmer is a recent open issue wasmerio/wasmer#4072 and wasmerio/wasmer#4059.

@Pratyush
Copy link
Member

Thanks for investigating this!

so it looks like an upstream bug. In that case let's add a note to the README indicating that currently we're limited to 1.67, and file an issue to bring back support for standard stable once the upstream issue is fixed.

@tyshko-rostyslav
Copy link
Collaborator Author

Thanks for investigating this!

so it looks like an upstream bug. In that case let's add a note to the README indicating that currently we're limited to 1.67, and file an issue to bring back support for standard stable once the upstream issue is fixed.

@Pratyush Done both. Issue here #53

README.md Outdated Show resolved Hide resolved
@Pratyush
Copy link
Member

Thanks! Tweaked the README message, and now this LGTM =)

@tyshko-rostyslav tyshko-rostyslav merged commit 507aa4f into master Jul 24, 2023
2 checks passed
@tyshko-rostyslav tyshko-rostyslav deleted the tyshko_rostyslav/issue-50-master-fail branch July 24, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master seems to failing testing
3 participants