Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Add the ed25519 curve #121

Merged
merged 8 commits into from
Oct 30, 2022
Merged

Add the ed25519 curve #121

merged 8 commits into from
Oct 30, 2022

Conversation

weikengchen
Copy link
Member

@weikengchen weikengchen commented Sep 4, 2022

Description

Needs a decision from Pratyush on whether or not we want to add ed25519.

In addition, related to #115, if we add this curve, we probably should add the curve25519 curve soon, which is to avoid users from thinking ed25519 is curve25519's twisted Edwards curve.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@weikengchen weikengchen changed the title Add ed25519 curve Add the ed25519 curve Sep 4, 2022
@weikengchen weikengchen mentioned this pull request Sep 5, 2022
6 tasks
@weikengchen
Copy link
Member Author

@arkworks-rs/algebra This one is ready for review.

ed25519/src/curves/mod.rs Outdated Show resolved Hide resolved
@weikengchen
Copy link
Member Author

fixed the comments:

    /// Standard generators from https://neuromancer.sk/std/other/Ed25519.

@weikengchen weikengchen merged commit a7d266f into master Oct 30, 2022
@weikengchen weikengchen deleted the ed25519 branch October 30, 2022 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants