Implemented proof rerandomization #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Do you have a link to the paper that proposes this randomization? It would be good to add this link to the comments. |
ValarDragon
reviewed
Dec 15, 2020
ValarDragon
reviewed
Dec 15, 2020
|
Thanks for the new feature, and for making the tests test across multiple curves! |
Pratyush
reviewed
Dec 16, 2020
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Pratyush
reviewed
Dec 16, 2020
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Pratyush
approved these changes
Dec 16, 2020
ValarDragon
approved these changes
Dec 16, 2020
|
It's noticeably faster to create a non-zk proof and then rerandomize it afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this functionality for a project I'm working on, and I figured it fits well into upstream. I also cleaned up the testing procedures.