Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify PolynomialCommitment trait: remove the generic on S: CryptographicSponge #145

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Simplify PolynomialCommitment trait: remove the generic on S: CryptographicSponge #145

wants to merge 14 commits into from

Conversation

mmagician
Copy link
Member

Description

Quality of life improvement for downstream users of the library.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@mmagician mmagician requested a review from a team as a code owner March 11, 2024 14:20
@mmagician mmagician requested review from z-tech, Pratyush and weikengchen and removed request for a team March 11, 2024 14:20
autquis
autquis reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@autquis autquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, indeed!

@autquis
Copy link
Contributor

autquis commented Mar 11, 2024

I pushed this to make the tests pass. I can also open another PR to the master for this and then you can rebase this one on that; let me know.

@mmagician
Copy link
Member Author

@autquis Thank you!

@mmagician
Copy link
Member Author

It's a bit annoying with that stable/nightly discrepancy on imports

@mmagician
clean up all imports
38ca957 
clean up imports acc to nightly

Revert "dont need to use full path"

This reverts commit b272524abeaa9f7d6697539f22682bc081e3e8a5.

more fmt
@mmagician
Copy link
Member Author

@autquis I had to undo your changes, as no-std was failing. In the end I ended up following the same strategy as https://github.com/arkworks-rs/algebra/pull/790/files#diff-6035356f5adc30af6393d5492dbc1d9d8ec187272030fdd95709b1b30f1275fc

@autquis
Copy link
Contributor

autquis commented Mar 12, 2024

I wonder, isn't it clenaer if we use #[cfg(not(feature = "std"))] for these imports?

@mmagician
Copy link
Member Author

That's worth exploring yes

@mmagician
Copy link
Member Author

The checks in #130 are failing. They've already been addressed here, we can either try to cherry pick the relevant commit to Hyrax, or merge this PR first and adapt Hyrax accordingly to remove the generic S. I'm in favor of the latter @Pratyush

@autquis
Copy link
Contributor

autquis commented Apr 7, 2024 •
edited
Loading

I added ark-std to the patch due to arkworks-rs/std#48
CI fails because of the same issue of imports in crypto-primitive. But poly-commit is fine now.

Also, I am doing a bit of cleaning up in the order of imports, as we are touching imports anyway.

@autquis
Copy link
Contributor

autquis commented Apr 7, 2024 •
edited
Loading

This PR depends now on arkworks-rs/crypto-primitives#142 Once that is merged, we can update Cargo.toml.

@autquis
Copy link
Contributor

autquis commented Apr 16, 2024

The PR is ready to be merged. @z-tech @Pratyush @weikengchen

@autquis
Copy link
Contributor

autquis commented May 1, 2024

Ping! Once this gets merged, I can move to the other PRs (Hyrax, Brakedown) and prepare them for being merged.

@autquis autquis force-pushed the no-generic-sponge branch 6 times, most recently from b3b04f2 to ef199a1 Compare May 27, 2024 09:13
@autquis
Copy link
Contributor

autquis commented May 27, 2024

Another ping. @weikengchen @Pratyush @z-tech

Also, it seems the cfg(not(feature("std"))) is no longer needed (rustc stable got upgraded). Once you review this, I'll remove them, and then, merge the PR, please. I'm not changing it now.

@autquis
Copy link
Contributor

autquis commented Jun 10, 2024

Gentle reminder @Pratyush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autquis autquis autquis left review comments

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@Pratyush Pratyush Awaiting requested review from Pratyush Pratyush is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmagician @autquis