New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CondSelectGadget for UInt
s
#20
Conversation
Amazing, thanks! Left some comments! |
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Suggestions all looked good to me. What does the |
By default |
Ahh I think the formatting got messed up, so if you could format then I can merge! |
Oops, looks like my |
Sorry just saw this; you want to run |
Cool, done! Thanks for reviewing! By the way, I was on |
This pull request is copied over from arkworks-rs/snark#312
It implements
CondSelectGadget
forUInt
constraint variables.UInt8
is implemented directly, while a macro is included to generate the implementation forUInt16
,UInt32
,UInt64
.A couple of things for review:
tracing
macro being used correctly? Should any of the inputs be skipped?value
when the inputs have no values correct?