Add DensePolynomialVar #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weikengchen
reviewed
Feb 4, 2021
|
Looks good. Currently, this is still a draft PR, is it ready, or more is going to be added? |
Yes, I believe it's ready. Let me open this PR. |
Pratyush
pushed a commit
that referenced
this pull request
Aug 8, 2021
* add folder structures similar to `ark-poly` * add evaluate impl for DensePolynomialVar * add tests * fix no-std * use ark_std::rand instead of SeedableRng * add changelog Co-authored-by: Weikeng Chen <w.k@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add DensePolynomialVar, which is a variable representing DensePolynomial similar in
ark-poly.closes: #49
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer