Move bench-utils into std, and simplify workspace
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
reviewed
Mar 19, 2021
|
LGTM sans the question about build profiles |
|
Ok let's merge this after the relevant PRs are made to the dependant crates. |
ValarDragon
approved these changes
Mar 19, 2021
|
btw, should we rename this repo to |
|
I agree with the renaming since the main one we use is |
weikengchen
approved these changes
Mar 20, 2021
This was referenced Mar 20, 2021
swasilyev
added a commit
to w3f/ring-vrf
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
bench-utilsintostd, thus simplifying the dependency story for downstream crates. It also makes it easier to publish things oncrates.io. cc @ValarDragon @weikengchen