Initial commit #1
Conversation
clarify the doc of the trait
| use crate::data_structures::ml_extension::{GKRFunction, MLExtension, SparseMLExtension}; | ||
|
|
||
| /// An implementation of multilinear extension, storing the data of underlying array. | ||
| pub struct MLExtensionArray<F: Field> { |
There was a problem hiding this comment.
There's a way to unify this with MLExtensionRefArray, by using Cow<'a, Vec<F>, like here: https://github.com/scipr-lab/poly-commit/blob/328c3df61ad433d3ba68a15958a516fc1953d627/src/data_structures.rs#L79
This should reduce the code duplication down the line.
There was a problem hiding this comment.
make sense. I will combine these two impl into one later
There was a problem hiding this comment.
Ok, maybe we should file an issue for it, and then revisit in a later PR?
There was a problem hiding this comment.
sounds good. I will do that
use new branch instead
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
|
Is the PR ready for another round of review? |
Yes. Thanks for reviewing the code! Really appreciate it |
|
resolved #3 |
|
For no_std mode, I recommend pulling in alloc as an external crate for Vec and String and so on |
This PR relocates code from my private repo.
for your convenience:
documentation
reference paper