Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated slovak translation #801

Closed
wants to merge 48 commits into from
Closed

Updated slovak translation #801

wants to merge 48 commits into from

Conversation

vschindler
Copy link

Updated slovak translation

@arkypita
Copy link
Owner

Hi @vschindler and thanks for your contribution.
Maybe I am wrong because I am not very expert of github system but look like you create the pull request in a wrong direction.

image

I think that the correct way to submit translation/code change is to fork your own copy of LaserGRBL and make your own branch (optional) than create pull request from your master/branch to arkypita/LaserGRBL:master

Like this:

image

However i have received slovak translation also from another user #851 and I think i'll import his file.

@vschindler
Copy link
Author

vschindler commented Jan 29, 2020 via email

@arkypita
Copy link
Owner

OK I would like to participate on the slovak translation. Upload his then I download the source and check it out. Then would try to create branch and pull request. Thank you

You are welcome.

This morning I have included slovak update from the other user into master branch.
You can branch from master and pull a merge request if you have refine to suggest.

Have a nice day

@arkypita arkypita closed this Jan 29, 2020
@vschindler
Copy link
Author

vschindler commented Jan 30, 2020 via email

@arkypita
Copy link
Owner

arkypita commented Feb 5, 2020

When I try to open file GrblConfig.resx an error occurs

What kind of error? Can you paste a screenshot in github? (attach image to email replay does not work in github).

@vschindler
Copy link
Author

vschindler commented Feb 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants