Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds option to hide clean flag #92

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Conversation

joshmedeski
Copy link
Contributor

Purpose

Adds the option for a user to hide the clean flag. I, personally, would rather not see anything as an indicator that everything is clean.

Approach

Add a hide_clean option that defaults to false and when set to true will not render the clean flag.

@arl
Copy link
Owner

arl commented Mar 8, 2023

Thanks @joshmedeski
Can you add some test please?
No need to be fancy, just a single test case showing off the feature.
Many examples are
https://github.com/arl/gitmux/blob/main/tmux/formater_test.go

Copy link
Owner

@arl arl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing that.

Nothing to add on the code side.

It would be nice to document the new flag.

in the default documentation:

In the README.md:

Thank you

@joshmedeski
Copy link
Contributor Author

All done, thanks :)

@arl arl merged commit 2d1c132 into arl:main Mar 16, 2023
@joshmedeski joshmedeski deleted the hide-clean branch March 16, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants