Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage with fasthttp? #12

Closed
zekroTJA opened this issue Oct 11, 2020 · 4 comments · Fixed by #35
Closed

Usage with fasthttp? #12

zekroTJA opened this issue Oct 11, 2020 · 4 comments · Fixed by #35
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers question Further information is requested

Comments

@zekroTJA
Copy link

Is it somehow possible to use this package with fasthttp as HTTP wrapper in combination with fasthttp-routing?

Because I really like the project and really want to integrate it into one of my projects which bases on these packages.

@arl
Copy link
Owner

arl commented Oct 11, 2020

I've never used fasthttp. If it's somewhat compatible with standard http.Handler then it might be possible, but I'm not sure.

Note that under the hood statsviz needs 2 handlers, the first for the web ui and the second for web socket.

You could also use net/http for statsviz and keep the rest of your application with fasthttp, apart from a slightly bigger binary size it shouldn't be a problem.
Let me know what you find

@arl arl added documentation Improvements or additions to documentation good first issue Good for newcomers question Further information is requested labels Oct 27, 2020
@nupamore
Copy link
Contributor

Http requests are simply resolved using fasthttpadaptor. But, there is a problem with the web socket. I'll make a PR for this problem.

@arl
Copy link
Owner

arl commented Nov 10, 2020

Hey @nupamore
Thank you to take care of that 👍
I'm assigning the issue to you

@arl
Copy link
Owner

arl commented Apr 25, 2021

Merged in #51 via #35

@arl arl closed this as completed Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants