Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #19

Closed
wants to merge 4 commits into from
Closed

Refactoring #19

wants to merge 4 commits into from

Conversation

pabloos
Copy link

@pabloos pabloos commented Oct 25, 2020

Hi there, here's some little refactorings

@arl
Copy link
Owner

arl commented Oct 25, 2020

Hey @pabloos thanks for your pull-request, that's much appreciated.

I've just finished and merged a pull-request I had started some time ago to improve the API, while remaining backward-compatible.
Some code has already been reorganized to improve readability/browse-ability.
Your PR has a lot of overlap with what I did.

Feel free to update your branch and propose another PR.
However the prototype of exported functions can't be changed since this would break compatibility.
Thanks again for your interest in statsviz

@pabloos
Copy link
Author

pabloos commented Oct 25, 2020

Ouch! Thanks, I had just updated my fork. I'm going to do a review it and create another PR.

Good job and thank you again!

@pabloos pabloos closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants