Skip to content
This repository has been archived by the owner on Jun 23, 2020. It is now read-only.

tmux-gitbar.conf needs to exist outside the repo #37

Closed
alexkornitzer opened this issue Nov 17, 2016 · 6 comments
Closed

tmux-gitbar.conf needs to exist outside the repo #37

alexkornitzer opened this issue Nov 17, 2016 · 6 comments

Comments

@alexkornitzer
Copy link
Contributor

Could you allow the option to have the tmux-gitbar.conf exist outside the repo? Apologies if this functionality already exists. Having the file exist in the repo makes it difficult to maintain the file across systems. I have tmux-gitbar as a submodule in my home folder setup which means I cannot manage the tmux-gitbar.conf across my machines. The conf file should really exist in the home folder anyway: ~/.tmux-gitbar.conf

@arl
Copy link
Owner

arl commented Nov 17, 2016

Hi Alex. I understand your problem, but in the currently state of things, i
dont think you can have it versioned without modifying tmux git bar code.
Why dont you fork it and allow a different path to tmux-gitbar.conf? In
case its not good enough for you i May resolve this when i have a bit of
time

Le 17 nov. 2016 15:49, "Alex Kornitzer" notifications@github.com a écrit :

Could you allow the option to have the tmux-gitbar.conf exist outside the
repo? Apologies if this functionality already exists. Having the file exist
in the repo makes it difficult to maintain the file across systems. I have
tmux-gitbar as a submodule in my home folder setup which means I cannot
manage the tmux-gitbar.conf across my machines. The conf file should really
exist in the home folder anyway: ~/.tmux-gitbar.conf


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#37, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAdF6ox88uDBoAQ84o8_ht3QU4el0FkIks5q_GlkgaJpZM4K1ZM1
.

@alexkornitzer
Copy link
Contributor Author

Hi Aurelien. If you are okay with me applying the changes I am happy to have a go at implementing this. Would you want me to PR back into the project or is this not the sort of feature you would want. If so what level would you want it at hardcoded to HOME or completely user definable?

@arl
Copy link
Owner

arl commented Nov 17, 2016

Thanks, a PR would be great! It believe it would be nice to have a sensible default for the config file location (in $HOME) that remains overridable by the user. Currently, tmux.gitbar.conf is auto-generated if it's not found in the project root directory.

@alexkornitzer
Copy link
Contributor Author

Awesome, already on the case. I nearly have it working so expect a PR soonish!

@arl
Copy link
Owner

arl commented Nov 17, 2016

Just have a look at the unit and integration test suite to be sure to not
break nothing😉. But dont bother run them locally, they will be be run on
Travis as soon as you open the PR. Cheers

Le 17 nov. 2016 17:47, "Alex Kornitzer" notifications@github.com a écrit :

Awesome, already on the case. I nearly have it working so expect a PR
soonish!


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#37 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdF6gvTtrew62CrByWh8Hb7GgiOKsFXks5q_IUvgaJpZM4K1ZM1
.

@arl
Copy link
Owner

arl commented Nov 20, 2016

fixed in #38

@arl arl closed this as completed Nov 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants