Attach meta data to message #50
Conversation
|
This is looking alright. Could you squash the commits and remove any changes to the build directory. I guess you're ok with fragmented messages always returning the same meta data. Also, you seem to be missing the path where messaged get stored for later delivery. I think that needs mending. |
|
Adding a test would be nice. |
(I've always wanted to use this task list :-)) |
|
How is the way to run your unit tests? Maybe you can give me short explanation. |
|
The test harness is mocha, which should be available when you |
| if ( this.REQUIRE_ENCRYPTION || | ||
| this.msgstate !== CONST.MSGSTATE_PLAINTEXT | ||
| ) { | ||
| msg = CryptoJS.enc.Utf8.parse(msg) | ||
| msg = msg.toString(CryptoJS.enc.Latin1) | ||
| } | ||
| this._sendMsg(msg) | ||
| this._sendMsg(msg, null, meta) |
There was a problem hiding this comment.
I think false is better than null here.
|
A final thing to add to your list: please update the documentation. Thanks for all the good work. |
|
Now I hope everything is satisfying. I also added my owncloud and sogo app to the "in the wild" section. |
|
Merged manually (needed a rebase). Thanks @sualko! |
According to #49