Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firs Round Of Fixes From E2E Scheduling Testing #2072

Merged
merged 6 commits into from
Jan 31, 2023

Conversation

d80tb7
Copy link
Collaborator

@d80tb7 d80tb7 commented Jan 31, 2023

  • Actually create job runs
  • Authentication setup to return error rather than panicing
  • Handle Durations correctly in db migration and executor api
  • Configure Allowed Priority Classes in Excecutor APi

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Base: 46.80% // Head: 46.75% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (900309e) compared to base (9815a53).
Patch coverage: 17.54% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2072      +/-   ##
==========================================
- Coverage   46.80%   46.75%   -0.06%     
==========================================
  Files         229      229              
  Lines       30186    30215      +29     
==========================================
- Hits        14129    14126       -3     
- Misses      15012    15042      +30     
- Partials     1045     1047       +2     
Flag Coverage Δ
airflow-operator 89.13% <ø> (ø)
armada-server 45.73% <17.54%> (-0.06%) ⬇️
python-client 93.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/scheduler/jobdb.go 81.19% <ø> (-0.16%) ⬇️
internal/scheduler/schedulerapp.go 0.00% <0.00%> (ø)
internal/scheduleringester/ingester.go 0.00% <0.00%> (ø)
internal/scheduler/api.go 66.18% <25.00%> (-2.99%) ⬇️
internal/scheduler/scheduler.go 77.38% <50.00%> (-0.14%) ⬇️
internal/scheduler/scheduling_algo.go 69.69% <100.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@d80tb7 d80tb7 merged commit 3b9ac8a into master Jan 31, 2023
@owenthomas17 owenthomas17 deleted the f/chrisma/fixes-from-scheduler-e2e branch August 25, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants