Added test file for cmd/armadactl/cmd/cancel_test.go #2418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2418 +/- ##
==========================================
+ Coverage 58.56% 58.60% +0.03%
==========================================
Files 231 231
Lines 28813 28813
==========================================
+ Hits 16875 16886 +11
+ Misses 10636 10624 -12
- Partials 1302 1303 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kannon92
reviewed
May 3, 2023
Updated the armada/cmd/armadactl/cmd/cancel_test.go, fixing lint issues.
Updated cancel_test.go file added as test file for armada/cmd/armadactl/cmd/cancel.go, fixing lint issues.
Fixed lint issues in armada/cmd/armadactl/cmd/cancel_test.go
* Make fake executor support cancellation We now track which pods are allocated to each node, so we can deallocate them correctly on cancellation Previously cancelled pods would just remain allocated forever and block all capacity on the cluster * Formatting
kannon92
suggested changes
May 5, 2023
|
I apologise for the inconvenience. The other account is not mine so I won't be able to remove its commits from this PR. Is it okay if I create another PR for this test file and close this one? |
|
Yea feel free to close and reopen. It’s no big deal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Issue #2167
Special notes for your reviewer:
┆Issue is synchronized with this Jira Task by Unito