New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
armbianmonitor - CPU temperature missing #839
Comments
Obviously only tested with |
I am on the way to fix this. |
Oh dear... I don't think Thomas will let you hear the end of this one for a while Igor! The fix is to remove the code which probably didn't get tested! At least the 🐛 has been 🔨 so now you can have 🍺 :-D :-D :-D |
Hello . I have noticed this problem again on ARMBIAN 5.38 stable Debian GNU/Linux 9 (stretch) 4.14.14-sunxi64 . |
IIRC there is a daemon service that does some background data collection (think this is the relevant bit?). |
The
[ ! -z "${SocTemp##*[0-9]*}" ]
test added in a recent commit 5cb346e#diff-9f87e1c4632903d6962052a358acebe1 toarmbianmonitor
has broken the temperature readings. Confirmed on at least three boards - OrangePiZero/legacy (me), pine64/legacy and odroidxu4/next (tkaiser).Basically, at the time the test is done at https://github.com/armbian/build/blob/master/packages/bsp/common/usr/bin/armbianmonitor#L346, the variable being used as a flag to indicate if the cputemp stuff should be done, and doesn't contain a valid temperature reading, so fails every time. It's not until the subsequent line that the script attempts to load the temperature data, so if it was wanted, it would have to be placed further down and wrap around https://github.com/armbian/build/blob/master/packages/bsp/common/usr/bin/armbianmonitor#L348-L351, and there will be decimals involved at some point. The updatemotd code that was in that commit works fine though.
The corresponding test for the PMIC will probably break also.
https://github.com/armbian/build/blob/master/packages/bsp/common/usr/bin/armbianmonitor#L353
The text was updated successfully, but these errors were encountered: