Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NanoPi M4V2 bring up #1646

Merged
merged 5 commits into from Dec 6, 2019
Merged

NanoPi M4V2 bring up #1646

merged 5 commits into from Dec 6, 2019

Conversation

piter75
Copy link
Member

@piter75 piter75 commented Nov 28, 2019

This PR will bring NanoPi M4V2 as CSC board using ddr/miniloader+bl31 combo for bootloader.
Could not get it to boot with TPL/SPL + BL31 reliably.

Removed links for legacy dts file names as the modern ones are referred explicitly in armbianEnv.txt file.

@chwe17
Copy link
Member

chwe17 commented Dec 6, 2019

considering we have a decent amount of those boards and you're working on it, I wouldn't add it as csc but straight go for wip (or is wip now deprecated? @igorpecovnik cause I don't see wip boards anymore)

@martinayotte
Copy link
Contributor

@chwe17, you don't see anymore WIP simply because most of those WIP, such OPi3, are now in Main Support...

@piter75
Copy link
Member Author

piter75 commented Dec 6, 2019

@chwe17 what a coincidence ;-) I was just going to write and ask the same thing.
I think we can wrap it up and merge it given that it has been tested and works quite well

@igorpecovnik I was also going to add it to targets.conf with similar configuration as classic M4, maybe swapping legacy/buster/minimal with current/buster/cli? Is it ok?

@piter75 piter75 marked this pull request as ready for review December 6, 2019 15:16
@martinayotte martinayotte merged commit c207e6c into master Dec 6, 2019
@chwe17
Copy link
Member

chwe17 commented Dec 6, 2019

@chwe17, you don't see anymore WIP simply because most of those WIP, such OPi3, are now in Main Support...

well I realized that those moved to supported.. but just wondering why we didn't had any wip boards.. So we're getting lazy? :D No more new boards? :P Don't tell this the forum community otherwise we get floated with new support requests.. 😈

[don't take everything serious here]

@martinayotte
Copy link
Contributor

@chwe17, just do a "git pull", you will see that this #1646 is now present as the only WIP ... :-P

@igorpecovnik
Copy link
Member

Yeah, only one WIP for now but this term is anyway liquid.

I was also going to add it to targets.conf with similar configuration as classic M4, maybe swapping legacy/buster/minimal with current/buster/cli? Is it ok?

You are welcome to swap things around if you feel so. This is anyway changing with time. Great job! I'll run stable image recreation for V2 and I am not sure shell I open a new board image at /download or just add a note main M4 download page?

@piter75
Copy link
Member Author

piter75 commented Dec 8, 2019

I'll run stable image recreation for V2

Great, Thanks!

I am not sure shell I open a new board image at /download or just add a note main M4 download page?

I would go with a separate page to lessen the confusion if that's not an issue.
It seems to be marketed as separate product and we also treat it as a separate board.

@igorpecovnik
Copy link
Member

@piter75
Copy link
Member Author

piter75 commented Dec 9, 2019

Thank you @igorpecovnik!

Could you please change two things on the page:

  1. Supported -> Suitable for testing (WIP)
  2. Set this image as board image:
    http://wiki.friendlyarm.com/wiki/images/3/32/NanoPi_M4V2-01B.jpg

Both are minor so they can be done whenever you find time... which I suppose may be hard ;p

@igorpecovnik
Copy link
Member

Supported -> Suitable for testing (WIP)

done

Set this image as board image

Most of the board photos are photographed by me because official are either low quality or doesn't came in high-resolution. Like this one. Can wait, yes.

@piter75 piter75 deleted the nanopi-m4v2-bring-up branch December 28, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants