Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add user path for configuration scan and check for NetworkManager #2721

Merged
merged 1 commit into from Apr 12, 2021
Merged

add user path for configuration scan and check for NetworkManager #2721

merged 1 commit into from Apr 12, 2021

Conversation

psztoch
Copy link
Collaborator

@psztoch psztoch commented Mar 16, 2021 •
edited

  1. More support for USERPATCHES_PATH.
  2. Redirect output to USERPATCHES_PATH/output if folder exists.
  3. Better logging for u-boot compilation.
  4. Better logging in configuration.sh for aggregated configs.
  5. New env DEBOOTSTRAP_OPTION.
  6. Detect NetworkManager and resolvconf before apply some patches (initial support for systemd-networkd and systemd-resolved).
  7. Purge extras-buildpkgs using PACKAGE_LIST_RM.
  8. Fixes for bullseye host compatibility.

@igorpecovnik
Copy link
Member

Are you perhaps in a mood to make this even more general way - adding an option to distinguish between network manager and systemd? If you don't have motivation to rework, I'll just merge it as is. Its fine.

@psztoch
Copy link
Collaborator Author

psztoch commented Mar 19, 2021 •
edited

But with systemd-networkd, I should replace ntp/chrony with systemd-timesyncd, and resolvconf with systemd-resolved too.
@igorpecovnik: Am I right?

@igorpecovnik
Copy link
Member

I think yes.

@igorpecovnik igorpecovnik force-pushed the master branch 2 times, most recently from 6f6643b to 757d9bc Compare April 7, 2021 11:01
@psztoch
Better user path config and support for etworkd
738996e 
add user path for configuration scan
check for NetworkManager/networkd
support for bullseye

(i.e. path: config/cli and files: packages, packages.remove)
@psztoch
Copy link
Collaborator Author

psztoch commented Apr 9, 2021

Please merge current state.
There is example configuration to use networkd:
echo "systemd-timesyncd" >> USERPATCHES/cli/bullseye/main/packages
echo "network-manager chrony hostapd resolvconf" >> USERPATCHES/cli/bullseye/main/packages.remove

@igorpecovnik igorpecovnik requested a review from a team April 9, 2021 11:18
@lanefu
Copy link
Member

lanefu commented Apr 11, 2021

Okay this is awesome... ill test and add to documentation

@lanefu lanefu self-assigned this Apr 11, 2021
@lanefu
Copy link
Member

lanefu commented Apr 11, 2021 •
edited

@psztoch what's a good set of parameters to use to test?

something like ? ./compile.sh EXPERT=yes BETA=yes SUBREVISION=-PR-2721 PACKAGE_LIST_RM="network-manager chrony"

@lanefu
Copy link
Member

lanefu commented Apr 11, 2021

I've spelled network-manager wrong 5 times while testing.. need more sleep... omitting crony worked.. trying again on network-manager

@lanefu
Copy link
Member

lanefu commented Apr 12, 2021

I still plan to do more testing but merging as it seems to not break anything and don't want to slow you down

@lanefu lanefu merged commit 59aa506 into armbian:master Apr 12, 2021
@psztoch
Copy link
Collaborator Author

psztoch commented Apr 12, 2021

@psztoch what's a good set of parameters to use to test?

something like ? ./compile.sh EXPERT=yes BETA=yes SUBREVISION=-PR-2721 PACKAGE_LIST_RM="network-manager chrony"

If you want to remove chrony, then you should add "systemd-timesyncd" to PACKAGE_LIST=.

My recommendation is to remove "resolveconf" and use systemd-resolved, too.
Then you can use all tools from systemd family.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lanefu lanefu

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@psztoch @igorpecovnik @lanefu