Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX armbian-ramlog default functionality breaking comments #3603

Merged
merged 1 commit into from Mar 29, 2022

Conversation

lanefu
Copy link
Member

@lanefu lanefu commented Mar 29, 2022

Description

resolves error during log rotation related to #2894

Syntax error: "(" unexpected

https://forum.armbian.com/topic/19564-making-espressobin-v7-work-in-2022/?do=findComment&comment=137468

Jira reference number AR-1135

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test Copied new config and applied it
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@lanefu lanefu requested a review from a team March 29, 2022 11:31
@github-actions github-actions bot removed the c:bsp label Mar 29, 2022
@lanefu
Copy link
Member Author

lanefu commented Mar 29, 2022

@igorpecovnik we should cherry pick into v20.02 if possible.

@igorpecovnik
Copy link
Member

... or make a bugfix release from master. Codebase hasn't been changed much - we are mainly fixing bugs.

@igorpecovnik igorpecovnik merged commit 3b05065 into armbian:master Mar 29, 2022
smlinux pushed a commit to smlinux/armbian-tanix-tx6 that referenced this pull request Mar 30, 2022
@lanefu
Copy link
Member Author

lanefu commented Apr 1, 2022

... or make a bugfix release from master. Codebase hasn't been changed much - we are mainly fixing bugs.

bugfix release from master is not a bug fix release :)

@igorpecovnik
Copy link
Member

Until all sources at release branch are not frozen, we can't say this neither.

littlecxm pushed a commit to littlecxm/armbian-build that referenced this pull request May 7, 2022
@lanefu lanefu deleted the fix_ramlog_rsync_bug branch January 20, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants