Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix spidev #3737

Merged
merged 8 commits into from May 12, 2022
Merged

Bugfix spidev #3737

merged 8 commits into from May 12, 2022

Conversation

The-going
Copy link
Contributor

@The-going The-going commented May 2, 2022

Description

This story with the spidev driver has been going on for quite a long time.
Kernel developers do not want this driver to be called by its name spidev.
They probably have serious reasons.

Starting from kernel version 5.15.1, we will be able to call, load this kernel module
only using an alias that should not match the name of this module.

This fix allows us to move in line with the upward changes of the kernel
and keep our patches of the dtb overlay files in working condition.

Please see this page.

Checklist:

Copy link
Member

@EvilOlaf EvilOlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@The-going
Copy link
Contributor Author

The-going commented May 2, 2022

Please take a look 617530a. This affects the Armbian brand.

@igorpecovnik if there are no objections to such changes, do I continue with kernel 5.15?

@igorpecovnik igorpecovnik added Hardware ⚙️ Work in progress Unfinished / work in progress and removed c:kernel labels May 2, 2022
@igorpecovnik
Copy link
Member

No objections. I think its fine.

@The-going
Copy link
Contributor Author

Well.

@The-going The-going force-pushed the bugfix-spidev branch 2 times, most recently from e745da2 to 2e14ae2 Compare May 12, 2022 12:15
@The-going The-going requested a review from EvilOlaf May 12, 2022 12:19
@The-going The-going added Ready to merge Reviewed, tested and ready for merge and removed Work in progress Unfinished / work in progress labels May 12, 2022
Copy link
Member

@EvilOlaf EvilOlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never played with SPI. Can neither approve nor reject.

Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it seems tested.

@igorpecovnik igorpecovnik merged commit ca478cc into armbian:master May 12, 2022
@Tonymac32
Copy link
Member

@armbian/board-maintainers

This impacts all board families kernel 5.15+. Please inform the other maintainers when finding a feature breaking change to the kernel that must be fixed.

@igorpecovnik
Copy link
Member

You mean we should extend this fix to all families?

@Tonymac32
Copy link
Member

Yes, it effects all families. torvalds/linux@6840615 makes the warning code unreachable as far as I can tell, so it fails silently on both Rockchip64 and Meson64 as tested by @rpardini and @lanefu

@The-going
Copy link
Contributor Author

Yes, I also confirm this.

@igorpecovnik
Copy link
Member

OK, this should go into a release. The one who will make a PR, should document it to Jira so it goes into the release log.

@rpardini
Copy link
Member

Heh, take a look at how rpi people are (not?) doing it, https://github.com/raspberrypi/linux/commits/rpi-5.17.y/drivers/spi/spidev.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Reviewed, tested and ready for merge
Development

Successfully merging this pull request may close these issues.

None yet

5 participants