New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix spidev #3737
Bugfix spidev #3737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently successful tested in forums: https://forum.armbian.com/topic/20033-51525-breaks-spi-on-nanopi-neo-and-does-not-create-devspidev00/?do=findComment&comment=139064
Please take a look 617530a. This affects the Armbian brand. @igorpecovnik if there are no objections to such changes, do I continue with kernel 5.15? |
No objections. I think its fine. |
Well. |
Add the armbian alias "spi-dev" to load and initialize the spidev module from the device tree.
e745da2
to
2e14ae2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never played with SPI. Can neither approve nor reject.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and it seems tested.
@armbian/board-maintainers This impacts all board families kernel 5.15+. Please inform the other maintainers when finding a feature breaking change to the kernel that must be fixed. |
You mean we should extend this fix to all families? |
Yes, it effects all families. torvalds/linux@6840615 makes the warning code unreachable as far as I can tell, so it fails silently on both Rockchip64 and Meson64 as tested by @rpardini and @lanefu |
Yes, I also confirm this. |
OK, this should go into a release. The one who will make a PR, should document it to Jira so it goes into the release log. |
Heh, take a look at how rpi people are (not?) doing it, https://github.com/raspberrypi/linux/commits/rpi-5.17.y/drivers/spi/spidev.c |
Description
This story with the spidev driver has been going on for quite a long time.
Kernel developers do not want this driver to be called by its name spidev.
They probably have serious reasons.
Starting from kernel version 5.15.1, we will be able to call, load this kernel module
only using an alias that should not match the name of this module.
This fix allows us to move in line with the upward changes of the kernel
and keep our patches of the dtb overlay files in working condition.
Please see this page.
Checklist: