Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need to read DISTRIBUTION_STATUS in order to have information about #3815

Merged
merged 3 commits into from May 25, 2022
Merged

We need to read DISTRIBUTION_STATUS in order to have information about #3815

merged 3 commits into from May 25, 2022

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented May 25, 2022 •
edited

Description

In first run script we show image support status but only in case image is not supported (nightly, self build, edge). We rely on information that is stored in /etc/armbian-distribution-status which is a part of BSP package.

Jira reference number AR-1197

How Has This Been Tested?

  • Generated image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge Bugfix Pull request is fixing a bug labels May 25, 2022
@igorpecovnik
Cover variants if we generate images for wip / csc targets
1decfe7 
- by mistake
- for promotion or other reasons
- if image is made by 3rd party to cover this case
@igorpecovnik igorpecovnik requested a review from a team May 25, 2022 15:33
lanefu
lanefu approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@lanefu lanefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sane

@igorpecovnik igorpecovnik merged commit 8d75c0b into master May 25, 2022
@igorpecovnik igorpecovnik deleted the AR-1197 branch May 25, 2022 16:35
zamentur pushed a commit to YunoHost/arm-images that referenced this pull request May 28, 2022
@igorpecovnik @zamentur
We need to read DISTRIBUTION_STATUS in order to have information about (
1da2e45 
armbian#3815)

* We need to read DISTRIBUTION_STATUS in order to have information about

* Cover variants if we generate images for wip / csc targets

- by mistake
- for promotion or other reasons
- if image is made by 3rd party to cover this case

* Update armbian-firstlogin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanefu lanefu lanefu approved these changes

Assignees
No one assigned
Labels
Bugfix Pull request is fixing a bug Ready to merge Reviewed, tested and ready for merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igorpecovnik @lanefu