Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in vagrant options handling #3975

Merged
merged 1 commit into from Jul 13, 2022

Conversation

dangoncalves
Copy link
Collaborator

Description

When compiling using vagrant as build environment, the first option following vagrant is skipped.

./compile.sh vagrant foo bar
In this example foo is skipped. This PR fix that bug.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • An image was successfully built using vagrant as builder.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@schwar3kat
Copy link
Contributor

The comment in the script says '#remove "vagrant" from the command line', but the patch description has "vagrant" in the command line. './compile.sh vagrant foo bar'

@dangoncalves
Copy link
Collaborator Author

Just updated the comment. The "vagrant" is useful to enter in config-vagrant.conf. Once we are in this file, we no longer need this option.

@schwar3kat schwar3kat requested a review from a team July 10, 2022 09:02
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge Bugfix Pull request is fixing a bug labels Jul 13, 2022
@igorpecovnik igorpecovnik merged commit aa38ab5 into armbian:master Jul 13, 2022
smlinux pushed a commit to smlinux/armbian-tanix-tx6 that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Pull request is fixing a bug Ready to merge Reviewed, tested and ready for merge
Development

Successfully merging this pull request may close these issues.

None yet

4 participants