Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rootfs cache refactoring #4057

Merged
merged 7 commits into from Aug 9, 2022
Merged

Rootfs cache refactoring #4057

merged 7 commits into from Aug 9, 2022

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Aug 9, 2022 •
edited

Description

  • this PR supports attaching to last cache release number at https://github.com/armbian/cache/releases
  • checks previous releases for file.
  • change compression method from lz4 to zsd to get better compression as we are hitting 2Gb file limits

Jira reference number AR-1277

How Has This Been Tested?

  • Made few images and caches

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@matthijskooijman
Copy link
Collaborator

@igorpecovnik I've seen the PR, but I am really busy this week, so I do not expect to be able to review it unfortunately.

@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Aug 9, 2022
@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress and removed Ready to merge Reviewed, tested and ready for merge labels Aug 9, 2022
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Work in progress Unfinished / work in progress labels Aug 9, 2022
@igorpecovnik igorpecovnik changed the title First part of rootfs cache refactoring Rootfs cache refactoring Aug 9, 2022
rpardini
rpardini approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@rpardini rpardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is very similar in spirit to what was done in armbian-next.
The speedup provided by zstdmt is great.

@igorpecovnik igorpecovnik merged commit e871b8e into master Aug 9, 2022
@igorpecovnik igorpecovnik deleted the AR-1277 branch August 9, 2022 22:17
iav
iav reviewed Aug 9, 2022
View reviewed changes
Copy link
Contributor

@iav iav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

smlinux pushed a commit to smlinux/armbian-tanix-tx6 that referenced this pull request Aug 11, 2022
@igorpecovnik @smlinux
Rootfs cache refactoring (armbian#4057)
18cc2ff 
* First part of rootfs cache refactoring

* Add support for checking previous caches.

* New default starting number

* Move back to n

* Add zstd compressor to the host dependencies

* Change cache compression to ZST

* Cleaning cache support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iav iav iav left review comments

@rpardini rpardini rpardini approved these changes

@matthijskooijman matthijskooijman Awaiting requested review from matthijskooijman

Assignees
No one assigned
Labels
Ready to merge Reviewed, tested and ready for merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@igorpecovnik @matthijskooijman @iav @rpardini