Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor download_and_verify #4172

Merged
merged 16 commits into from
Sep 22, 2022
Merged

Refactor download_and_verify #4172

merged 16 commits into from
Sep 22, 2022

Conversation

hzyitc
Copy link
Member

@hzyitc hzyitc commented Sep 12, 2022

Description

  • Bugfix: We didn't delete the downloaded file when verification failed. So it can be used in next time.
  • Bugfix: Incorrent CCODE to query mirrors of cache.armbian.com
  • Support download rootfs cache from Github
  • Always require signature file
  • Remove some useless requests

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Run the build script

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Sep 13, 2022
@hzyitc hzyitc removed the Work in progress Unfinished / work in progress label Sep 21, 2022
igorpecovnik
igorpecovnik approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on first review. This refactoring reminds me we have to enable some cache mirrors in China. Before they were a part of the main mirror package ...

If it download works for toolchains and they build something that works, we are good to go.

@hzyitc hzyitc merged commit 8b2b14d into armbian:master Sep 22, 2022
@hzyitc hzyitc deleted the refactor-download_and_verify branch September 22, 2022 09:31
smlinux pushed a commit to smlinux/armbian-tanix-tx6 that referenced this pull request Sep 23, 2022
@hzyitc @smlinux
Refactor download_and_verify (armbian#4172)
9cc9a22 
* Split out decompress code from `download_and_verify`

* Clean the code to recieve keys

* Split out `aria2_options` array

* Tweak `aria2_options`

* `download_and_verify` always require `asc` file

* Download torrent from multi origin

* Refactor `get_urls` which renamed from `webseed`

* Add Github source to download rootfs cache

* Remove some useless check

* Change the argument of `download_and_verify`

* We don't need `complete` file

* Delete files when verification failed

* Adapt the refactored `download_and_verify`

* Remove useless config `ARMBIAN_MIRROR`

* Bugfix: verify never fail

* Specify directory argument instand of cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hzyitc @igorpecovnik