Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shebangs for shellcheck #4493

Merged
merged 2 commits into from
Nov 27, 2022
Merged

Add shebangs for shellcheck #4493

merged 2 commits into from
Nov 27, 2022

Conversation

ashthespy
Copy link
Collaborator

Description

Low hanging fruit..
Add bash shebang at the start of all .sh files

Jira reference number AR-1406

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Also for `extensions` scripts
@ashthespy
Copy link
Collaborator Author

ashthespy commented Nov 26, 2022

FWIW there are also some missing in packages
Would you like me to align those as well?

File Shebang
./packages/blobs/jetson/jetson.sh #!/bin/sh
./packages/bsp/aml-s9xx-box/root/install-aml-s905-emmc.sh #!/bin/sh
./packages/bsp/aml-s9xx-box/root/install-aml.sh #!/bin/sh
./packages/bsp/common/etc/initramfs-tools/hooks/bootsplash.sh #!/bin/sh
./packages/bsp/common/etc/profile.d/armbian-activate-profile-sync-daemon.sh #!/bin/sh
./packages/bsp/common/etc/profile.d/armbian-check-first-login-reboot.sh #!/bin/sh
./packages/bsp/common/etc/profile.d/armbian-check-first-login.sh #!/bin/sh
./packages/bsp/common/etc/profile.d/armbian-lang.sh
./packages/bsp/common/etc/profile.d/armbian-ssh-title.sh #!/bin/sh
./packages/bsp/common/usr/lib/armbian/armbian-led-state-restore.sh #!/bin/bash
./packages/bsp/common/usr/lib/armbian/armbian-led-state-save.sh #!/bin/bash
./packages/bsp/helios64/helios64-ups.sh #!/bin/sh
./packages/bsp/jethub/jethub-remove-log-file.sh #!/bin/bash
./packages/bsp/mvebu/helios4/mdadm-fault-led.sh #!/bin/sh
./packages/bsp/nanopim4/nanopim4-pwm-fan.sh #!/bin/bash
./packages/bsp/odroid/c1_init.sh #!/bin/sh
./packages/bsp/odroid/c2_init.sh #!/bin/sh
./packages/bsp/rk3328/z28pro/start_bt.sh #!/bin/bash
./packages/bsp/rockchip/start_bt.sh #!/bin/bash
./packages/bsp/sunxi/zeroplus2-bt.sh #!/bin/bash
./packages/extras-buildpkgs/hostapd/debian/ifupdown/hostapd.sh #!/bin/sh
./packages/extras-buildpkgs/hostapd-realtek/debian/ifupdown/hostapd.sh #!/bin/sh
./packages/extras-buildpkgs/libvdpau-sunxi/debian/profile.d/99-vdpau.sh

@igorpecovnik
Copy link
Member

Would you like me to align those as well?

As its looks like this operation is safe, I would rather just leave that.

@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Nov 27, 2022
@igorpecovnik igorpecovnik merged commit 408bc67 into armbian:master Nov 27, 2022
@ashthespy ashthespy deleted the shebangs branch November 27, 2022 21:10
smlinux pushed a commit to smlinux/armbian-tanix-tx6 that referenced this pull request Dec 4, 2022
* Add shebangs for shellcheck

See #AR-1406

* Add shebangs for shellcheck

Also for `extensions` scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Reviewed, tested and ready for merge
Development

Successfully merging this pull request may close these issues.

None yet

2 participants