Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI beta build for Orange Pi 5, fix desktop build #4651

Merged
merged 1 commit into from Jan 4, 2023

Conversation

efectn
Copy link
Member

@efectn efectn commented Jan 3, 2023

Description

Beta builds are not able to start X11 since 3dsupport group is exists on images. Oibaf PPA is definitely incompatible with RK3588 boards. It's not also exists on main target config.

  • I also added beta build option for CLI. If you are not OK to that, i can remove it.

How Has This Been Tested?

  • I didn't test it but i'm sure 3dsupport breaks X11 on RK3588 boards. (I built an image that have Oibaf PPA and it wasn't also able to get X11)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@efectn efectn requested a review from a team as a code owner January 3, 2023 21:07
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Completely forgot about this.

@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Jan 3, 2023
@igorpecovnik igorpecovnik merged commit f6bc760 into armbian:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Reviewed, tested and ready for merge
Development

Successfully merging this pull request may close these issues.

None yet

3 participants