Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtlwifi: Fix p2p-go advertising #4717

Merged
merged 1 commit into from Jan 20, 2023
Merged

rtlwifi: Fix p2p-go advertising #4717

merged 1 commit into from Jan 20, 2023

Conversation

Azq2
Copy link
Collaborator

@Azq2 Azq2 commented Jan 20, 2023

Description

Backported PR from jwrdegoede/rtl8189ES_linux#87 to all other wifi drivers. (similar to #4661)

Need to fix, but currently skipped:

  • rtl8723cs: This driver was added to each kernel separately. Impossible to maintain. Need move driver to separated repo and add to the drivers_network.sh.
  • rtl8723bs: have different code base, can't easily be ported.

How Has This Been Tested?

  • It's builds without errors.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Azq2
Copy link
Collaborator Author

Azq2 commented Jan 20, 2023

Of course, I didn't test this due to lack of hardware. But, anyway, this code is only related to P2P and doesn't affect any other modes.
Also without these changes p2p is unusable.

@igorpecovnik
Copy link
Member

rtl8723cs: This driver was added to each kernel separately. Impossible to maintain.

I have open a Jira to not forget about https://armbian.atlassian.net/browse/AR-1503 and I did move another which is probably not affected.

@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Jan 20, 2023
@igorpecovnik igorpecovnik merged commit 4c5f202 into armbian:master Jan 20, 2023
smlinux pushed a commit to smlinux/armbian-tanix-tx6 that referenced this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Reviewed, tested and ready for merge
Development

Successfully merging this pull request may close these issues.

None yet

2 participants