Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update boot-sunxi.cmd #5002

Merged
merged 4 commits into from Mar 28, 2023
Merged

Update boot-sunxi.cmd #5002

merged 4 commits into from Mar 28, 2023

Conversation

CueMaxX
Copy link
Contributor

@CueMaxX CueMaxX commented Mar 25, 2023

Description

'setenv console "display"' in boot-sunxi.cmd & in armbianEnv.txt had the same effect as 'setenv console "both"'. That was due to a false if-statement in boot-sunxi.cmd:41 Fixed that, so 'setenv console "display"' will not co-enable the serial console anymore. No dependencies required.

Jira reference number: [n/a]

How Has This Been Tested?

Test A: Executed mkimage on BananaPi. Yielded results as expected.

  • Test A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [n/a] I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [n/a] Any dependent changes have been merged and published in downstream modules

EvilOlaf and others added 2 commits February 21, 2023 18:04
@EvilOlaf
Add deprecation note (armbian#4845)
95c829f
@CueMaxX
Update boot-sunxi.cmd
5484a07 
'setenv console "display"' in boot-sunxi.cmd & in armbianEnv.txt had the same effect as 'setenv console "both"'.
That was due to a false if-statement in boot-sunxi.cmd:41
Fixed that, so 'setenv console "display"' will not co-enable the serial console anymore.
@CueMaxX CueMaxX requested a review from a team as a code owner March 25, 2023 09:53
igorpecovnik
igorpecovnik previously approved these changes Mar 26, 2023
View reviewed changes
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Mar 26, 2023
@igorpecovnik igorpecovnik changed the base branch from master to main March 26, 2023 18:55
@igorpecovnik igorpecovnik dismissed their stale review March 26, 2023 18:55

The base branch was changed.

@igorpecovnik igorpecovnik merged commit 765ff69 into armbian:main Mar 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvilOlaf EvilOlaf EvilOlaf approved these changes

@igorpecovnik igorpecovnik igorpecovnik left review comments

@littlecxm littlecxm Awaiting requested review from littlecxm

@TheLinuxBug TheLinuxBug Awaiting requested review from TheLinuxBug

@TRSx80 TRSx80 Awaiting requested review from TRSx80

Assignees
No one assigned
Labels
Ready to merge Reviewed, tested and ready for merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CueMaxX @EvilOlaf @igorpecovnik