Add CSC Board Indiedroid Nova #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r8169 driver for ethernets and RTL8821CS for wifi
lanefu
requested review from
amazingfate,
catalinii and
igorpecovnik
as code owners
|
In the kernel config diff a ton of wireless "m"'s get wiped out, was that on purpose? |
Blerg. I blame EXTRAWIFI FLAG |
Yeah, that was one of the few advantages of having EXTRAWIFI=yes forced. |
|
Maybe a "are you sure?" Pause if it's not set to yes?
…On Thu, Jul 20, 2023, 6:29 AM Ricardo Pardini ***@***.***> wrote:
Blerg. I blame EXTRAWIFI FLAG
Yeah, that was one of the few advantages of having EXTRAWIFI=yes forced.
Maybe we should force it for kernel-config command?
—
Reply to this email directly, view it on GitHub
<#5493 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEVNQAEVDXXWJI3DJMLPILXREB65ANCNFSM6AAAAAA2QV2G5U>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
But it now only matters when its explicitly set to no. So unless someone specifically set it to no, the modules must be present in the kernel tree. So I will not blame the flag, mostly its simply a user error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add community support configuration (CSC) for RK3588s Indiedroid Nova.
Updated rk3588 legacy kernel config to enable r8169 driver for ethernets and RTL8821CS for wifi
Current State