tmpfs: introduce USE_TMPFS=no to disable tmpfs usage for WORKDIR and package-specific working dirs; actually use $temp_dir_id for mktemp; see #5502
#5506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and package-specific working dirs; actually use `$temp_dir_id` for mktemp; see armbian#5502 - `USE_TMPFS=no` disables usage of generic tmpfs mechanism (still possibly used for rootfs/image building, which is unrelated), for last-resort cases - use better/more descriptive `temp_dir_id`'s for kernel build than `k` (now `kernel_dest_install_dir`) and `kd` (now `kernel_debs_temp_dir`) - specific image/dtb/headers packaging already had decent names, same for other .deb's - replace `mktemp -d` with `mktemp -d --tmpdir "${temp_dir_id}-XXXXX"` in `prepare_temp_dir_in_workdir_and_schedule_cleanup()`, so we know what's using what in tmpfs
1 task
viraniac
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
CC'ing @viraniac who I think had also troubles with tmpfs? Also @prahal -- this might workaround the problems in #5218
I don't think I had issues with tmpfs. The memory usage shown by docker never hit above the limit mentioned in docker resources settings even when I compiled debug kernels with custom configurations that resulted into 200MB initrd file. I did had issues with initrd not fitting into the memory used in our bootscripts, but modified the same and was good to go.
Anyways coming back to the PR, the changes looks ok. Hence approving the request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmpfs: introduceUSE_TMPFS=noto disable tmpfs usage for WORKDIR and package-specific working dirs; actually use$temp_dir_idfor mktemp; see #5502tmpfs: introduceUSE_TMPFS=noto disable tmpfs usage for WORKDIR and package-specific working dirs; actually use$temp_dir_idfor mktemp; see During build process: cp: error writing '/home/user/build/.tmp/work-XXXXXXXX: No space left on device #5502USE_TMPFS=nodisables usage of generic tmpfs mechanism (still possibly used for rootfs/image building, which is unrelated), for last-resort casestemp_dir_id's for kernel build thank(nowkernel_dest_install_dir) andkd(nowkernel_debs_temp_dir)mktemp -dwithmktemp -d --tmpdir "${temp_dir_id}-XXXXX"inprepare_temp_dir_in_workdir_and_schedule_cleanup(), so we know what's using what in tmpfs