-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Linux Mint release support in host-release.sh #5540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see other places in the build code that could possibly require this change:
extensions/sunxi-tools.sh L12
config/sources/families/include/crust_firmware.inc L26
lib/functions/image/partitioning.sh L42
@rpardini @viraniac - perhaps at some stage in future this should be consolidated in a single variable?
Yes, the values do need to be added here. This is because the compiler needed to compile crust is not available before debian bookworm, ubuntu 22.04 and their equivalent version of linux mint. Once we drop support for older host OSes, we can have the code defined without if block.
I think we should have that mkopts directly now, all the older OSes than whats mentioned there are declared EOL by their respective vendors. @rpardini thougts? |
We've had multiple discussions on this. This is disabling the following features (from
In my understanding, this was introduced when those features were "new", and older kernels couldn't cope with them. |
Then changing this PR to drop them all? https://armbian.atlassian.net/browse/AR-1811 |
I like this approach. Keeps it simple. I'm also in favor of anything that could build a more a robust rootfs, even if the resize is slower, if this is now feasible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.