Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel 6.5 armbian-led-state.service order #5674

Conversation

schwar3kat
Copy link
Contributor

@schwar3kat schwar3kat commented Sep 4, 2023

Description

A change to ledtrig_netdev driver causes the boot to fail on Orangepi-r1plus-lts and possibly other boards.
The board boots and LED netdev trigger works if service is modified to occur later in the boot sequence by using After=timers.target in armbian-led-state.service.

Jira reference number AR-1875
Issue discussion rockchip64: bump rockchip64-edge kernel to 6.5#5657

How Has This Been Tested?

Tested on current and 6.5y Rockchip64 and other (H5).
The following configurations were tested for boot, reboot and shutdown then boot and that LED's light when network is connected and LED's flicker on network activity:

  • Orangepi R1 Plus LTS with Kernel 6.5y with ledtrig_netdev configured for two ethernet ports and two LED's.
  • Orangepi R1 Plus LTS with Kernel 6.1y with ledtrig_netdev configured for two ethernet ports and two LED's.
  • Orangepi Zero Plus with Kernel 6.5y with ledtrig_netdev configured for one ethernet ports and one LED.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

A change to ledtrig_netdev causes the boot to fail on Orangepi-r1plus-lts and possibly other boards. The board boots and LED netdev trigger works if service is modified to use After=timers.target.
@schwar3kat schwar3kat requested a review from a team as a code owner September 4, 2023 02:46
@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Sep 4, 2023
@igorpecovnik igorpecovnik merged commit 169155c into armbian:main Sep 4, 2023
4 checks passed
@paolosabatino
Copy link
Contributor

paolosabatino commented Sep 4, 2023

Just a note: perhaps it is a good idea to let the script run after both timers.target and local-fs.target if possible, if timers.target is not already implicitly run after local-fs.target

@schwar3kat
Copy link
Contributor Author

schwar3kat commented Sep 4, 2023

implicitly run after local-fs.target

@paolosabatino - I assumed this because it runs so late. (I picked the latest, that I could see in the logs). But your question prompted me to check if this is true.

systemd-analyze dump shows unit timers.target is after sysinit.target which is after local-fs.target, so it's safe to leave it, noting that it got approved and merged overnight (for me in NZ).

We could possibly have used sysinit.target instead (although it occurred several seconds earlier).

@schwar3kat schwar3kat deleted the Kernel-6.5-armbian-led-state.service-order branch September 4, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Reviewed, tested and ready for merge
Development

Successfully merging this pull request may close these issues.

None yet

3 participants