New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable artifacts creation at pull request #5804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorpecovnik
force-pushed
the
AR-1886
branch
11 times, most recently
from
October 8, 2023 07:27
3c3d985
to
1b3e10f
Compare
igorpecovnik
force-pushed
the
AR-1886
branch
2 times, most recently
from
October 8, 2023 08:38
5b18b99
to
275212b
Compare
igorpecovnik
requested review from
Tonymac32,
schwar3kat,
sgjava,
teknoid and
viraniac
as code owners
October 8, 2023 08:38
igorpecovnik
force-pushed
the
AR-1886
branch
3 times, most recently
from
October 8, 2023 11:34
acc1d16
to
e1926de
Compare
igorpecovnik
force-pushed
the
AR-1886
branch
2 times, most recently
from
October 8, 2023 14:28
a919489
to
f9bc042
Compare
I am curious about the change in linux-sunxi-edge.config, was that done for testing purpose or is it required for something? |
this. |
igorpecovnik
force-pushed
the
AR-1886
branch
5 times, most recently
from
October 11, 2023 07:46
6e969b0
to
b2dd290
Compare
igorpecovnik
changed the title
Add action for artifacts creation at pull request
Enable artifacts creation at pull request
Oct 12, 2023
/build |
/rebase |
/build |
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the long missing important feature at the pull request stage is pre-merge build test. Of any artifact. This implement a call to use our standard build-all-artifacts action script with additional parameters: we need to attach build framework to PR commit ID and tell script that we don’t need to upload or download artifacts to / from ORAS cache. For security reasons, this will be done separately.
Build script will run only when comment /build is added to the PR by Armbian organisation member that is part of "Release manager" team.
Jira reference number AR-1886
How Has This Been Tested?
Checklist: