Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable artifacts creation at pull request #5804

Merged
merged 10 commits into from Nov 8, 2023
Merged

Enable artifacts creation at pull request #5804

merged 10 commits into from Nov 8, 2023

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Oct 8, 2023

Description

One of the long missing important feature at the pull request stage is pre-merge build test. Of any artifact. This implement a call to use our standard build-all-artifacts action script with additional parameters: we need to attach build framework to PR commit ID and tell script that we don’t need to upload or download artifacts to / from ORAS cache. For security reasons, this will be done separately.

Build script will run only when comment /build is added to the PR by Armbian organisation member that is part of "Release manager" team.

Jira reference number AR-1886

How Has This Been Tested?

  • PR executes actions
  • When PR is updated, active workflow is canceled, new starts
  • Artifacts are not pushed to ORAS cache

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik force-pushed the AR-1886 branch 11 times, most recently from 3c3d985 to 1b3e10f Compare October 8, 2023 07:27
@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Oct 8, 2023
@viraniac
Copy link
Collaborator

viraniac commented Oct 9, 2023

I am curious about the change in linux-sunxi-edge.config, was that done for testing purpose or is it required for something?

@igorpecovnik
Copy link
Member Author

was that done for testing purpose

this.

@igorpecovnik igorpecovnik changed the title Add action for artifacts creation at pull request Enable artifacts creation at pull request Oct 12, 2023
@igorpecovnik
Copy link
Member Author

/build

@igorpecovnik
Copy link
Member Author

/rebase

@igorpecovnik
Copy link
Member Author

/build

@igorpecovnik
Copy link
Member Author

/build

@igorpecovnik igorpecovnik merged commit 47f8065 into main Nov 8, 2023
5 checks passed
@igorpecovnik igorpecovnik deleted the AR-1886 branch November 8, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants