Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the VENDOR in motd after the update #5922

Merged
merged 1 commit into from Nov 16, 2023
Merged

Keep the VENDOR in motd after the update #5922

merged 1 commit into from Nov 16, 2023

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Nov 15, 2023 •
edited

Description

On images with changed vendor, when update comes from Armbian repository, VENDOR is overwritten. This change keeps the VENDOR variable from image.

How Has This Been Tested?

  • Manual run

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik marked this pull request as ready for review November 15, 2023 23:20
@igorpecovnik igorpecovnik requested a review from a team as a code owner November 15, 2023 23:20
@igorpecovnik igorpecovnik added Bugfix Pull request is fixing a bug 11 Milestone: Fourth quarter release Needs review Seeking for review labels Nov 15, 2023
schwar3kat
schwar3kat approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@schwar3kat schwar3kat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorpecovnik igorpecovnik merged commit b5d5acc into main Nov 16, 2023
26 of 31 checks passed
@igorpecovnik igorpecovnik deleted the anon-cosemtic branch November 16, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schwar3kat schwar3kat schwar3kat approved these changes

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release Bugfix Pull request is fixing a bug Needs review Seeking for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igorpecovnik @schwar3kat