Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme.md Improve structure, UX, and fix links to download pages #5929

Merged
merged 3 commits into from Nov 20, 2023
Merged

Readme.md Improve structure, UX, and fix links to download pages #5929

merged 3 commits into from Nov 20, 2023

Conversation

igorpecovnik
Copy link
Member

Description

Several changes to welcome text.

How Has This Been Tested?

n/a

Checklist:

  • I have made corresponding changes to the documentation

@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Nov 18, 2023
@igorpecovnik igorpecovnik changed the title Improve structure, UX, and fix links to download pages Readme.md Improve structure, UX, and fix links to download pages Nov 18, 2023
EvilOlaf
EvilOlaf reviewed Nov 18, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
EvilOlaf
EvilOlaf reviewed Nov 18, 2023
View reviewed changes
Copy link
Member

@EvilOlaf EvilOlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comment

@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Needs review Seeking for review and removed Work in progress Unfinished / work in progress labels Nov 19, 2023
@github-actions github-actions bot added the size/small PR with less then 50 lines label Nov 19, 2023
viraniac
viraniac approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@viraniac viraniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there a way to get the urls from some variable from the repo configuration? If yes, then probably we should use that. That will also be a step towards anonymizing the build framework.

@igorpecovnik
Copy link
Member Author

If yes, then probably we should use that. That will also be a step towards anonymizing the build framework.

Lets see and wait how Armbian-unofficial will help. Perhaps this is enough?
https://github.com/armbian/build/blob/main/lib/functions/configuration/main-config.sh#L41-L42

@igorpecovnik igorpecovnik merged commit 12b87bb into main Nov 20, 2023
8 checks passed
@igorpecovnik igorpecovnik deleted the readme branch November 20, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viraniac viraniac viraniac approved these changes

@littlecxm littlecxm Awaiting requested review from littlecxm littlecxm is a code owner

@TRSx80 TRSx80 Awaiting requested review from TRSx80 TRSx80 is a code owner

@EvilOlaf EvilOlaf Awaiting requested review from EvilOlaf EvilOlaf is a code owner

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release Needs review Seeking for review size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@igorpecovnik @EvilOlaf @viraniac