Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockchip,rk322x: fix gpio,i2c group creation #6023

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

paolosabatino
Copy link
Contributor

@paolosabatino paolosabatino commented Dec 8, 2023

Description

As specified in PR #5967, there was a nasty mistake in rockchip and rk322x source files that were attempting to create two groups (gpio and i2c) on the building host instead of the built image. This caused the build system to crash when the groups were already present on the building host, which is totally not desiderable, and the intended feature was also broken.

After some inspection, the groups were leveraged by a couple of udev rules to allow non-root users have access to gpio and i2c resources out of the box. This PR fixes the group creation on the target built image.

Note: gpio and i2c gids starts from 900 because gids nearby 1000 are already taken by some existing services.
Note 2: this supersedes #5967 which can be closed as well.

Jira reference number AR-1935

How Has This Been Tested?

  • Compile debian bookworm for rockchip family, verify the presence of groups in target image
  • Compile debian bookworm for rk322x family, verify the present of groups in target image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@paolosabatino paolosabatino requested a review from a team December 8, 2023 20:03
@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related - kernel, u-boot, patches labels Dec 8, 2023
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge Bugfix Pull request is fixing a bug 02 Milestone: First quarter release labels Dec 9, 2023
@igorpecovnik igorpecovnik merged commit 5599e23 into armbian:main Dec 9, 2023
9 checks passed
@paolosabatino paolosabatino deleted the AR-1935 branch December 9, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Bugfix Pull request is fixing a bug Hardware Hardware related - kernel, u-boot, patches Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

None yet

2 participants