Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename board config: micro.csc to olimex-a20-olinuxino-micro #6254

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

Kreyren
Copy link
Contributor

@Kreyren Kreyren commented Feb 5, 2024

Description

Submitted upon request to make user's life easier.

How Has This Been Tested?

No need. Just name adjustment and CSC board.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Submitted upon request to make user's life easier
@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related - kernel, u-boot, patches labels Feb 5, 2024
@viraniac
Copy link
Collaborator

viraniac commented Feb 5, 2024

Its already there, hence closing - https://github.com/armbian/build/blob/main/config/boards/micro.csc

@viraniac viraniac closed this Feb 5, 2024
@Kreyren
Copy link
Contributor Author

Kreyren commented Feb 5, 2024

Its already there, hence closing - https://github.com/armbian/build/blob/main/config/boards/micro.csc -- @viraniac (#6254 (comment))

$ diff ./config/boards/{olimex-a20-olinuxino-micro.csc,micro.csc}
5c5
< BOOTCONFIG="A20-OLinuXino_MICRO_defconfig"
---
> BOOTCONFIG="A20-OLinuXino_MICRO-eMMC_defconfig"

doggy-eyeswall

@viraniac viraniac reopened this Feb 5, 2024
@viraniac
Copy link
Collaborator

viraniac commented Feb 5, 2024

Thanks for pointing it out. I see dts is almost the same. Only changes are in MMC_SLOT_EXTRA value, I think it may be possible to handle it in some other way like how multiple u-boots are done for clearfog. But even if there is no other way, this can cause confusion to users. Probably we also need to rename either the old board or the new one to avoid the confusion

@viraniac
Copy link
Collaborator

viraniac commented Feb 5, 2024

Also there might be changes needed in the comment on the top of the file?

@Kreyren
Copy link
Contributor Author

Kreyren commented Feb 5, 2024

i've just done minimal changes so that the user can test the contribution and know what they are testing instead of being overwhelmed with changes that's why this is set as draft that shouldn't be subject to any review yet unless requested

@viraniac
Copy link
Collaborator

viraniac commented Feb 5, 2024

yes I noticed its draft and their will be changes coming. Not a review comment, was just pointing that out to make sure its not missed :)

@viraniac viraniac added the Work in progress Unfinished / work in progress label Feb 5, 2024
@igorpecovnik
Copy link
Member

emmc variant can cover both.

@igorpecovnik
Copy link
Member

same as here and done.
https://github.com/armbian/build/blob/main/config/boards/lime2.csc#L5

@Goosegit11
Copy link

I'm building it right now

@Goosegit11
Copy link

Goosegit11 commented Feb 6, 2024

It failed to compile

Last ~70 lines (error): https://0x0.st/HkwG.txt

full log: https://paste.armbian.com/xuwasitula

@viraniac
Copy link
Collaborator

viraniac commented Feb 6, 2024

use bullseye or bookworm instead of using buster

@Kreyren
Copy link
Contributor Author

Kreyren commented Feb 7, 2024

Actually rather trixie or sid

@igorpecovnik
Copy link
Member

igorpecovnik commented Feb 7, 2024

Otherwise we have this config for years, just its named micro.csc. I know its not correct, but why bother? Rename it.

@igorpecovnik
Copy link
Member

@Kreyren Rename micro.csc to this or close PR as we already have this hw, just named differently.

@igorpecovnik igorpecovnik added the 05 Milestone: Second quarter release label Feb 10, 2024
@Kreyren
Copy link
Contributor Author

Kreyren commented Feb 11, 2024

@Goosegit11 were you able to test the image?

@Goosegit11
Copy link

Goosegit11 commented Feb 11, 2024

@Kreyren Tried with bullseye, it booted, asked me "Create root password" and other questions, after this "installation" it doesn't boot anymore, sadly.

And what do you think about what Igor says?

@Kreyren
Copy link
Contributor Author

Kreyren commented Feb 12, 2024

@Kreyren Tried with bullseye, it booted, asked me "Create root password" and other questions, after this "installation" it doesn't boot anymore, sadly. -- @Goosegit11 (#6254 (comment))

🤔

afaik that happens if you kill the power to the system as it's resizing the rootfs partition during the first installation prompt (after root password) that then results in rootfs corruption. Can you try again?

And what do you think about what Igor says? -- @Goosegit11 (#6254 (comment))

He says lot of things.. we ain't at the state where i need to comment on things yet when the board doesn't work reliably

@igorpecovnik igorpecovnik marked this pull request as ready for review February 28, 2024 12:26
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Work in progress Unfinished / work in progress labels Feb 28, 2024
@igorpecovnik igorpecovnik changed the title olimex-a20-olinuxino-micro: New board Rename board config: micro.csc to olimex-a20-olinuxino-micro Feb 28, 2024
@igorpecovnik igorpecovnik merged commit 25b0a83 into armbian:main Feb 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release Hardware Hardware related - kernel, u-boot, patches Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

None yet

4 participants