Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable release upgrade checking on release manager #6298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Feb 24, 2024

Description

We probably don't want to bother people with upstream release upgrades as they are outside our power.

How Has This Been Tested?

Tested:

sudo apt-get install ubuntu-release-upgrader-core
sudo do-release-upgrade -d
Checking for a new Ubuntu release
In /etc/update-manager/release-upgrades Prompt 
is set to never so upgrading is not possible.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the size/small PR with less then 50 lines label Feb 24, 2024
@igorpecovnik igorpecovnik marked this pull request as ready for review February 26, 2024 12:58
@igorpecovnik igorpecovnik requested a review from a team as a code owner February 26, 2024 12:58
@igorpecovnik igorpecovnik added 05 Milestone: Second quarter release Needs review Seeking for review labels Feb 26, 2024
@iav
Copy link
Contributor

iav commented Mar 4, 2024

Image can't be build, because

[🐳|🌱] Copying host-side apt list cache into image [ apt-get update and clean image-side ]
[🐳|🔨]   mkdir: created directory '/armbian/.tmp/rootfs-83fc53ca-7671-4c86-a218-6ef02e47689d/var/lib/apt/lists'
[🐳|🌱] After copying host-side cache into image [ 58 files ]
[🐳|🌱] Updating apt lists in image [ apt-get update and clean ]
[🐳|🔨]   Hit:1 http://ports.ubuntu.com mantic InRelease
[🐳|🔨]   Hit:2 http://ports.ubuntu.com mantic-security InRelease
[🐳|🔨]   Hit:3 http://ports.ubuntu.com mantic-updates InRelease
[🐳|🔨]   Hit:5 http://ports.ubuntu.com mantic-backports InRelease
[🐳|🔨]   Ign:4 http://fi.mirror.armbian.de/apt mantic InRelease
[🐳|🔨]   Err:6 http://fi.mirror.armbian.de/apt mantic Release
[🐳|🔨]     404  Not Found [IP: 65.21.120.247 80]
[🐳|🔨]   Reading package lists...
[🐳|🔨]   E: The repository 'http://apt.armbian.com mantic Release' no longer has a Release file.
[🐳|💥] Error 100 occurred in main shell [ at /armbian/lib/functions/logging/runners.sh:211

@iav
Copy link
Contributor

iav commented Mar 4, 2024

Mmm... funny.
I can't create new image of deprecated release to run test of deprecation workaround :)

@iav
Copy link
Contributor

iav commented Mar 4, 2024

I have one running system on mantic, but how this fix should jump there (skip possibility when I manualy apply config file to system).

@EvilOlaf
Copy link
Member

EvilOlaf commented Mar 4, 2024

I assume mantic shouldn't have been abandoned just yet. It is still supported upstream until July 2024

@igorpecovnik
Copy link
Member Author

Mantic repo is back.

@iav
Copy link
Contributor

iav commented Mar 10, 2024

On fresh-generated image with proposed fix:

root@rockpi-4a:/etc# apt install ubuntu-release-upgrader-core
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following NEW packages will be installed:
  ubuntu-release-upgrader-core
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/25.6 kB of archives.
After this operation, 270 kB of additional disk space will be used.
(Reading database ... 40419 files and directories currently installed.)
Preparing to unpack .../ubuntu-release-upgrader-core_1%3a23.10.14_all.deb ...
Unpacking ubuntu-release-upgrader-core (1:23.10.14) ...
dpkg: error processing archive /var/cache/apt/archives/ubuntu-release-upgrader-core_1%3a23.10.14_all.deb (--unpack):
 trying to overwrite '/etc/update-manager/release-upgrades', which is also in package armbian-bsp-cli-rockpi-4a-edge 24.5.0-trunk
Errors were encountered while processing:
 /var/cache/apt/archives/ubuntu-release-upgrader-core_1%3a23.10.14_all.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)
root@rockpi-4a:/etc#

TL;DR:
package ubuntu-release-upgrader-core can't be installed. At least, as usual package.
Is it desired behaviour?

I think it's something wrong.

@igorpecovnik
Copy link
Member Author

Is it desired behaviour?

No. Will fix this...

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress and removed Needs review Seeking for review labels Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release size/small PR with less then 50 lines Work in progress Unfinished / work in progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants