Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: Update forked-helper and add some doc on secrets in workflow's README.md #6375

Merged
merged 2 commits into from Mar 9, 2024

Conversation

ColorfulRhino
Copy link
Collaborator

Description

::set-output has been deprecated in 2022: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Thus replacing it with >> $GITHUB_OUTPUT as described in the guide above.

Also, took me a while to figure out how to create and use the ARMBIAN_SELF_DISPATCH_TOKEN mentioned in the readme. So I updated the readme accordingly so others don't have to spend time figuring it out on their own in the future.
(This helped me a lot: https://github.com/peter-evans/repository-dispatch?tab=readme-ov-file#token)

How Has This Been Tested?

  • Ran the workflow on my forked repo without issues.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added Action scripts GitHub Action scripts size/small PR with less then 50 lines labels Mar 8, 2024
@igorpecovnik igorpecovnik added 05 Milestone: Second quarter release Needs review Seeking for review labels Mar 8, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Mar 9, 2024
@igorpecovnik igorpecovnik merged commit 8cd1a3d into armbian:main Mar 9, 2024
11 checks passed
@ColorfulRhino ColorfulRhino deleted the workflow-updates branch March 9, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release Action scripts GitHub Action scripts Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

None yet

2 participants