armbian-kernel: drop DEBUG_KERNEL/DEBUG_INFO disables; force EXPERT=y and bring back CONFIG_GPIO_SYSFS=y for all kernels
#6580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ERT=y` and bring back `CONFIG_GPIO_SYSFS=y` for all kernels - we had `_DEBUG=n` forced, which conflicted with `_EXPERT=y`; - some important SBC features (like _GPIO_SYSFS) depend on _EXPERT=y - we've plans to enable BTF/CO-RE kernels soon, so removing the non-debug enforcement makes some sense - also, .config's will be free to determine debug config, nothing's changing in those here - remove the `_EMBEDDED` special case handling, we can do that as well now - add a separate hook to renable `CONFIG_GPIO_SYSFS=y`; it was a victim of `EXPERT=n` in some kernels - this does not include rewrites of all the .configs -- those should be done in a separate batch -- either way effect is the same, hooks will always override .config's - during rewrites, a large number of new options will show up, since `_EXPERT=y` is used as dependency for many of Kernel's experimental-ish features
|
Yes I know, I know... it's late in release cycle for this stuff. Not-disabling DEBUG info is different than enabling it, though -- here we really just need After release, I will propose DEBUG/BTF forced-enablement and a rewrite of all .config's to defconfig. |
igorpecovnik
added
Ready to merge
igorpecovnik
approved these changes
May 11, 2024
|
thanks for wrangling a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
armbian-kernel: drop
DEBUG_KERNEL/DEBUG_INFOdisables; forceEXPERT=yand bring backCONFIG_GPIO_SYSFS=yfor all kernelsDEBUG_KERNEL/DEBUG_INFOdisables; forceEXPERT=yand bring backCONFIG_GPIO_SYSFS=yfor all kernels_DEBUG=nforced, which conflicted with_EXPERT=y;_EMBEDDEDspecial case handling, we can do that as well nowCONFIG_GPIO_SYSFS=y; it was a victim ofEXPERT=nin some kernels_EXPERT=yis used as dependency for many of Kernel's experimental-ish features