Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTS-check: Python librarires have troubles to build, disabling for now #6798

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jun 25, 2024

Description

  • disable
  • add requirements.txt to Dockerfile generation

How Has This Been Tested?

  • Manual build passes

Checklist:

  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

- Add requirements.txt to Dockerfile generation
@igorpecovnik igorpecovnik requested a review from a team as a code owner June 25, 2024 06:11
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Jun 25, 2024
igorpecovnik referenced this pull request Jun 25, 2024
This makes dependencies easier to track and opens up the possibility for Dependabot to update them.
@igorpecovnik igorpecovnik added 08 Milestone: Third quarter release Bugfix Pull request is fixing a bug labels Jun 25, 2024
@igorpecovnik igorpecovnik merged commit 024c086 into main Jun 25, 2024
12 checks passed
@igorpecovnik igorpecovnik deleted the pythons branch June 25, 2024 06:53
@ColorfulRhino
Copy link
Collaborator

Can you please link a log file? Everything worked fine when building on my machine, like last time.

However, I specifically warned that it might cause some unknown CI issue #6739 (comment)

Unfortunately, the "Build" label did not work to test this (GITHUB_TOKEN still misconfigured somehow?)

@igorpecovnik
Copy link
Member Author

igorpecovnik commented Jun 25, 2024

Can you please link a log file?

7aadb80#commitcomment-143491819

Everything worked fine when building on my machine, like last time.

I had to rebuild things at once, so I had to workaround it adhoc.

@ColorfulRhino
Copy link
Collaborator

Can you please link a log file?

7aadb80#commitcomment-143491819

Thanks! Github does not send a notification for comments on commits unfortunately, so I did not see it.

@ColorfulRhino
Copy link
Collaborator

From 7aadb80#commitcomment-143506110 :

It seems that the source of the error is

collect2: fatal error: cannot find ‘ld’

Which means ld is missing in PATH. I think I have fixed it, will send a PR soon.

Also, your build host (Ubuntu 22?) seems to use a quite old version of setuptools.

ERROR: setuptools==59.6.0 is used in combination with setuptools_scm>=8.x
[🐳|🔨]         
[🐳|🔨]         Your build configuration is incomplete and previously worked by accident!
[🐳|🔨]         setuptools_scm requires setuptools>=61

I might fix this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Bugfix Pull request is fixing a bug Framework Framework components size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

None yet

2 participants