Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bsp-cli/bsp-desktop: hashing fixes #6838

Merged
merged 1 commit into from
Jul 2, 2024
Merged

bsp-cli/bsp-desktop: hashing fixes #6838

merged 1 commit into from
Jul 2, 2024

Conversation

rpardini
Copy link
Member

bsp-cli/bsp-desktop: hashing fixes

  • bsp-cli/bsp-desktop: hashing fixes
    • both artifacts use functions in the bsp/utils-bsp.sh file, which wasn't being hashed
    • bsp-cli hashed non-existent 'packages/bsp-cli' directory, remove
    • bsp-cli: be verbose when rsync'ing packages/bsp/common
    • force sync in a few strategic spots
    • utils-bsp.sh: be verbose when copying files (incl config/optional stuff)

@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Jun 30, 2024
@rpardini rpardini marked this pull request as ready for review June 30, 2024 11:36
@rpardini rpardini requested a review from a team as a code owner June 30, 2024 11:36
@rpardini rpardini force-pushed the pr/bsp-clibsp-desktop-hashing-fixes branch from a3162a5 to 391847f Compare June 30, 2024 14:53
@viraniac
Copy link
Collaborator

The dirs_to_hash and PACKAGES_SEARCH_ROOT_ABSOLUTE_DIRS array are having same values. Can we merge them together and also add a way so that more directories can be added there when required for a board or family? That way all the raw files will get hashed automatically. Only functions will have to be taken care of.

@rpardini rpardini force-pushed the pr/bsp-clibsp-desktop-hashing-fixes branch from 391847f to 303c3f3 Compare June 30, 2024 19:32
@rpardini
Copy link
Member Author

Can we merge them together and also add a way so that more directories can be added there when required for a board or family

Yeah, some refactoring so default list can be shared, and using a two-phase scheme (init array, call hook to populate array, then hash resulting array) can be implemented. Here I'm just trying to fix the bugs for a bsp-cli release.

@rpardini rpardini force-pushed the pr/bsp-clibsp-desktop-hashing-fixes branch 2 times, most recently from 3ad501c to 44d8d38 Compare July 2, 2024 09:50
@rpardini
bsp-cli/bsp-desktop: hashing fixes
cf4744c 
- both artifacts use functions in the bsp/utils-bsp.sh file, which wasn't being hashed
- bsp-cli hashed non-existent 'packages/bsp-cli' directory, remove
- bsp-cli: be verbose when rsync'ing `packages/bsp/common`
- force sync in a few strategic spots
- utils-bsp.sh: be verbose when copying files (incl `config/optional` stuff)
@rpardini rpardini force-pushed the pr/bsp-clibsp-desktop-hashing-fixes branch from 44d8d38 to cf4744c Compare July 2, 2024 19:19
@rpardini
Copy link
Member Author

rpardini commented Jul 2, 2024

I'm pretty tired of rebasing this. Can @armbian/build-scripts review this please?

ColorfulRhino
ColorfulRhino approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@ColorfulRhino ColorfulRhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry!

I don't know much about the functionality, but the code looks good 👍

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release labels Jul 2, 2024
@igorpecovnik igorpecovnik merged commit c5697cf into armbian:main Jul 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColorfulRhino ColorfulRhino ColorfulRhino approved these changes

@EvilOlaf EvilOlaf Awaiting requested review from EvilOlaf

@igorpecovnik igorpecovnik Awaiting requested review from igorpecovnik

Assignees
No one assigned
Labels
08 Milestone: Third quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rpardini @viraniac @ColorfulRhino @igorpecovnik