Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanopi-r5s: u-boot: pci enum in preboot; disable armbian-led-state #6896

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rpardini
Copy link
Member

@rpardini rpardini commented Jul 6, 2024

nanopi-r5s: u-boot: pci enum in preboot; disable armbian-led-state

  • nanopi-r5s: u-boot: pci enum in preboot; disable armbian-led-state
    • pci enum in preboot; required for working m.2 when booting some older kernels
    • this board has an overlay (DEFAULT_OVERLAYS="nanopi-r5s-leds") to drive the LEDs, disable armbian-led-state service

@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related - kernel, u-boot, patches labels Jul 6, 2024
@rpardini rpardini marked this pull request as ready for review July 6, 2024 23:21
function post_config_uboot_target__extra_configs_for_nanopi-r5s() {
display_alert "u-boot for ${BOARD}" "u-boot: enable preboot & flash all LEDs in preboot" "info"
[[ "${BRANCH}" == "edge" || "${BRANCH}" == "current" ]] || return 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NanoPi R5S doesn't have any branch besides edge and current?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a leak. (I've a separate commit adding vendor to this board, which is not ready yet). It shouldn't hurt, though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate commit adding vendor to this board

NanoPi R5 and RK3568 are pretty well supported on mainline, there's not much to gain from vendor kernel vs the added complexity imo this is a step backwards 😅 Been running on edge ever since on my R5C and never missed any feature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a very specific need: the Realtek NIC's MAC can only be fused using Realtek tools that only work on 5.10 legacy kernel. @TheLinuxBug provided me with an ancient vendor image, no longer offered by FE, which worked, so I think I gave up on this effort.

Otherwise: vendor would offer video accel not available on mainline, or am I mistaken?

@rpardini rpardini force-pushed the pr/nanopi-r5s-u-boot-pci-enum-in-preboot-disable-armbian-led-state branch from 1164fa5 to 795b6da Compare July 7, 2024 11:11
- pci enum in preboot; required for working m.2 when booting some older kernels
- this board has an overlay (DEFAULT_OVERLAYS="nanopi-r5s-leds") to drive the LEDs, disable armbian-led-state service
@rpardini rpardini force-pushed the pr/nanopi-r5s-u-boot-pci-enum-in-preboot-disable-armbian-led-state branch from 795b6da to 6c0d7c7 Compare July 8, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Hardware related - kernel, u-boot, patches size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

None yet

3 participants