Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Firefly-ROC-RK3328-CC #921

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Conversation

daijh223
Copy link

@daijh223 daijh223 commented Apr 9, 2018

please add support for firefly-roc-rk3328-cc

roc-rk3328-cc wiki:http://en.t-firefly.com/doc/product/info/381.html#

@igorpecovnik
Copy link
Member

We don't need new family. Use rk3328 and only add u-boot patch for this particular board if needed. U-boot is unique for each board and userspace changes are packed into boards support package. Specifics can be added to family config -> sources/rk3328.conf

Please rework. Thanks!

@daijh223
Copy link
Author

daijh223 commented Apr 9, 2018

@igorpecovnik
Do you mean that the same chip can't modify the BOARDFAMILY ?
Is BOARDFAMILY only equal to rk3328?
But in the sources/rk3328.conf file :
BOOTSOURCE='https://github.com/ayufan-rock64/linux-u-boot'
......
ATFSOURCE='https://github.com/ayufan-rock64/arm-trusted-firmware'
......
KERNELSOURCE='https://github.com/ayufan-rock64/linux-kernel'
......
All come from a particular board(rock64)

If I want to add support to my board, can I only use rock64 source code and add my patch?

@Tonymac32
Copy link
Member

Tonymac32 commented Apr 9, 2018 via email

@ThomasKaiser
Copy link
Contributor

I too vote for using ayufan's kernel for whatever RK3328 (and RK3399) device.

@daijh223
Copy link
Author

I made some changes to my first submission.Only add kernel dts ,config/boards/roc-rk3328-cc.wip,and u-boot patch for roc-rk3328-cc.

@igorpecovnik
Copy link
Member

This is much better. Only one tiny remark (you can leave it as is) - we usually don't store full u-boot config. I don't have other complaints. Until official maintainer is not set, a board can actually be a .csc target (community supported), not .wip. We don't have this hardware so end-user support is not possible.

@daijh223
Copy link
Author

daijh223 commented Apr 11, 2018

I'm sorry.I haven't thought consummately.now i change .wip to .csc

@igorpecovnik igorpecovnik merged commit 032c789 into armbian:master Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants